Skip to content

Add explicit constructors #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kimkulling merged 1 commit into from
Oct 16, 2025
Merged

Add explicit constructors #45

kimkulling merged 1 commit into from
Oct 16, 2025

Conversation

@kimkulling
Copy link
Owner

@kimkulling kimkulling commented Oct 16, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Added bounds checking to string element access to prevent out-of-bounds errors and improve stability.

  • Refactor

    • Enhanced type safety by preventing implicit type conversions in template class constructors.
    • Simplified isEmpty() implementation.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes make two template constructors explicit to prevent implicit conversions (TBitField and TOptional), and enhance TStringBase by adding bounds checking to operator[] with simplified isEmpty() syntax.

Changes

Cohort / File(s) Summary
Constructor Explicitness
include/cppcore/Common/TBitField.h, include/cppcore/Common/TOptional.h		 Added explicit keyword to single-argument constructors for both TBitField and TOptional to prevent unintended implicit type conversions.
String Base Improvements
include/cppcore/Common/TStringBase.h		 Added bounds checking in operator[] to return 0 for out-of-bounds indices; simplified isEmpty() by removing unnecessary parentheses around comparison.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Cleanup interface #37: Modifies TBitField constructor signatures (sets default constructor to =default and adjusts init constructor), directly related to this PR's explicit keyword addition to TBitField.

Poem

🐰 Explicit paths and bounds so tight,
No sneaky conversions in the night,
Safe array access, gentle and clear,
Defensive code brings programmers cheer! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch review/explicit_ctr
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5f2a8 and 11f2f20.

📒 Files selected for processing (3)
  • include/cppcore/Common/TBitField.h (1 hunks)
  • include/cppcore/Common/TOptional.h (1 hunks)
  • include/cppcore/Common/TStringBase.h (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kimkulling kimkulling merged commit 058de86 into main Oct 16, 2025
2 checks passed
@kimkulling kimkulling deleted the review/explicit_ctr branch October 16, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kimkulling